commit 579667537a4bb6029d19ed46fcc7ace2fdca1cad
author dan <dan@noemail.net> Sat Apr 09 17:32:58 2011 +0000
committer dan <dan@noemail.net> Sat Apr 09 17:32:58 2011 +0000
tree 03d8c4d5e8cb28de5a2d6107990d5f17cf395cbc
parent 7687c83d4c8837e42d6b813695fec95afd00dc9d

Add VerifyCookie instructions to "DROP XXX IF EXISTS" statements if the specified database object does not exist when the statement is prepared.

FossilOrigin-Name: a46f32900a013aa6bb2dad2a9ed3ce00ab2493fd

src/build.c

diff --git a/src/build.c b/src/build.c
index 2d1d8dc..83a1db8 100644
--- a/src/build.c
+++ b/src/build.c
@@ -2003,6 +2003,7 @@
   if( noErr ) db->suppressErr--;
 
   if( pTab==0 ){
+    if( noErr ) sqlite3CodeVerifyNamedSchema(pParse, pName->a[0].zDatabase);
     goto exit_drop_table;
   }
   iDb = sqlite3SchemaToIndex(db, pTab->pSchema);
@@ -2917,6 +2918,8 @@
   if( pIndex==0 ){
     if( !ifExists ){
       sqlite3ErrorMsg(pParse, "no such index: %S", pName, 0);
+    }else{
+      sqlite3CodeVerifyNamedSchema(pParse, pName->a[0].zDatabase);
     }
     pParse->checkSchema = 1;
     goto exit_drop_index;
@@ -3507,6 +3510,21 @@
 }
 
 /*
+** If argument zDb is NULL, then call sqlite3CodeVerifySchema() for each 
+** attached database. Otherwise, invoke it for the database named zDb only.
+*/
+void sqlite3CodeVerifyNamedSchema(Parse *pParse, const char *zDb){
+  sqlite3 *db = pParse->db;
+  int i;
+  for(i=0; i<db->nDb; i++){
+    Db *pDb = &db->aDb[i];
+    if( pDb->pBt && (!zDb || 0==sqlite3StrICmp(zDb, pDb->zName)) ){
+      sqlite3CodeVerifySchema(pParse, i);
+    }
+  }
+}
+
+/*
 ** Generate VDBE code that prepares for doing an operation that
 ** might change the database.
 **

src/sqliteInt.h

diff --git a/src/sqliteInt.h b/src/sqliteInt.h
index d663742..ea0925e 100644
--- a/src/sqliteInt.h
+++ b/src/sqliteInt.h
@@ -2768,6 +2768,7 @@
 void sqlite3PrngResetState(void);
 void sqlite3RollbackAll(sqlite3*);
 void sqlite3CodeVerifySchema(Parse*, int);
+void sqlite3CodeVerifyNamedSchema(Parse*, const char *zDb);
 void sqlite3BeginTransaction(Parse*, int);
 void sqlite3CommitTransaction(Parse*);
 void sqlite3RollbackTransaction(Parse*);

src/trigger.c

diff --git a/src/trigger.c b/src/trigger.c
index 8952ad5..0f3f5ba 100644
--- a/src/trigger.c
+++ b/src/trigger.c
@@ -502,6 +502,8 @@
   if( !pTrigger ){
     if( !noErr ){
       sqlite3ErrorMsg(pParse, "no such trigger: %S", pName, 0);
+    }else{
+      sqlite3CodeVerifyNamedSchema(pParse, zDb);
     }
     pParse->checkSchema = 1;
     goto drop_trigger_cleanup;