don't enable no_default_deps in msan build
This is fix for
https://ci.chromium.org/ui/p/chromium/builders/ci/ToTLinuxMSan/17162/overview
Bug: 1374606
Change-Id: I6cbda739bbbacd6892f134097aba616d6c4779b0
diff --git a/BUILD.gn b/BUILD.gn
index 1439dd0..bbf0f0e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -7,6 +7,8 @@
configs_to_delete = [ "//build/config/compiler:chromium_code" ]
+should_remove_default_deps_for_performance = false
+
# We'd like to disable sanitizers in all cases, but this is not possible with
# MSAN due to its linkage with instrumented libraries. https://crbug.com/928357
if (!is_msan) {
@@ -14,6 +16,14 @@
# Don't enable sanitizers for build tools. They slow down the overall build.
"//build/config/sanitizers:default_sanitizer_flags",
]
+
+ # Without no_default_deps, an implicit dependency on libc++ is added.
+ # libc++ may have been built referencing the debug CRT, but since we're
+ # explicitly using the release CRT, this would result in undefined symbol
+ # errors when linking, so we need to remove the implicit libc++ dependency.
+ # This is also needed to remove some configurations which make nasm's
+ # performance slow.
+ should_remove_default_deps_for_performance = true
}
configs_to_add = [ "//build/config/compiler:no_chromium_code" ]
@@ -118,12 +128,6 @@
"//build/win:default_exe_manifest",
]
- # Without no_default_deps, an implicit dependency on libc++ is added.
- # libc++ may have been built referencing the debug CRT, but since we're
- # explicitly using the release CRT, this would result in undefined symbol
- # errors when linking, so we need to remove the implicit libc++ dependency.
- # This is also needed to remove some configurations which make nasm's
- # performance slow.
- no_default_deps = true
+ no_default_deps = should_remove_default_deps_for_performance
}
}