commit b9195402b41a4ec8e6141c31ff7b6c6561a29b3d
author David Benjamin <davidben@google.com> Fri Aug 05 10:51:43 2016 -0400
committer Adam Langley <agl@google.com> Fri Aug 05 19:00:33 2016 +0000
tree 977605a5d6a92d4331b92e34bd5e6256e9be8a4e
parent a9c3bf142e5425313a2197fcc84451b879d89237

Align SSL_SESSION_up_ref with OpenSSL.

Only X509_up_ref left (it's still waiting on a few external callers).

BUG=89

Change-Id: Ia2aec2bb0a944356cb1ce29f3b58a26bdb8a9977
Reviewed-on: https://boringssl-review.googlesource.com/9141
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>

ssl/handshake_client.c

diff --git a/ssl/handshake_client.c b/ssl/handshake_client.c
index 850b2bc..0b50505 100644
--- a/ssl/handshake_client.c
+++ b/ssl/handshake_client.c
@@ -508,7 +508,8 @@
 
         SSL_SESSION_free(ssl->s3->established_session);
         if (ssl->session != NULL) {
-          ssl->s3->established_session = SSL_SESSION_up_ref(ssl->session);
+          SSL_SESSION_up_ref(ssl->session);
+          ssl->s3->established_session = ssl->session;
         } else {
           /* We make a copy of the session in order to maintain the immutability
            * of the new established_session due to False Start. The caller may