commit 7e1f984a7c4eede37d6297cba141aef7de4509b0
author David Benjamin <davidben@google.com> Tue Sep 20 19:24:40 2016 -0400
committer David Benjamin <davidben@google.com> Wed Sep 21 20:40:10 2016 +0000
tree 0b699b02867fa1a341b9c8e0e89618f8034c8c13
parent e4706906336f8724a25b68f82967dcf82d2fb45e

Fix some bugs in TLS 1.3 server key_share code.

Found by libFuzzer and then one more mistake caught by valgrind. Add a
test for this case.

Change-Id: I92773bc1231bafe5fc069e8568d93ac0df4c8acb
Reviewed-on: https://boringssl-review.googlesource.com/11129
Reviewed-by: David Benjamin <davidben@google.com>

ssl/tls13_server.c

diff --git a/ssl/tls13_server.c b/ssl/tls13_server.c
index 4cfd265..53e5363 100644
--- a/ssl/tls13_server.c
+++ b/ssl/tls13_server.c
@@ -88,7 +88,7 @@
   int found_key_share;
   uint8_t *dhe_secret;
   size_t dhe_secret_len;
-  uint8_t alert;
+  uint8_t alert = SSL_AD_DECODE_ERROR;
   if (!ssl_ext_key_share_parse_clienthello(ssl, &found_key_share, &dhe_secret,
                                            &dhe_secret_len, &alert,
                                            &key_share)) {