munmap() buffers after running bsdiff in main.
We were technically leaking mmap'ed memory in the main program. This
was not really a problem in normal execution of the binary because the
process would finish right after it, but releasing the mmap() helps
find actual leaks when instrumenting the code with asan tools.
Bug: None
Test: ran bsdiff over a sample file.
Change-Id: I5fac808ba6d0ba9b2331e40a764cac1a3620062f
diff --git a/bsdiff_main.cc b/bsdiff_main.cc
index 1465441..6747055 100644
--- a/bsdiff_main.cc
+++ b/bsdiff_main.cc
@@ -85,8 +85,13 @@
return 1;
}
- return bsdiff::bsdiff(old_buf, oldsize, new_buf, newsize,
- arguments.min_length(), patch_writer.get(), nullptr);
+ int ret = bsdiff::bsdiff(old_buf, oldsize, new_buf, newsize,
+ arguments.min_length(), patch_writer.get(), nullptr);
+
+ munmap(old_buf, oldsize);
+ munmap(new_buf, newsize);
+
+ return ret;
}
void PrintUsage(const std::string& proc_name) {